Support slice ops with default start #9923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9923
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4322f80 with merge base b7eee0c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72503552 |
mcr229
approved these changes
Apr 6, 2025
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Apr 6, 2025
Summary:
Since D71962884, we see the following slice ops in ASR encoder:
{F1976830836}
This is causing failure during XNNPack delegation, since XNNPack slice pass is trying to compare start_idx 'None' to 0.
This diff fixes that.
Reviewed By: mcr229
Differential Revision: D72503552
pssrawat
force-pushed
the
export-D72503552
branch
from
bfe6e5c to
6922356
Compare
Summary: Pull Request resolved: pytorch#9923 Since D71962884, we see the following slice ops in ASR encoder: {F1976830836} This is causing failure during XNNPack delegation, since XNNPack slice pass is trying to compare start_idx 'None' to 0. This diff fixes that. Reviewed By: mcr229 Differential Revision: D72503552
|
This pull request was exported from Phabricator. Differential Revision: D72503552 |
pssrawat
force-pushed
the
export-D72503552
branch
from
6922356 to
4322f80
Compare
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D72503552 Pull Request resolved: #9923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since a recent change we see None arg in the slice op
This is causing failure during XNNPack delegation, since XNNPack slice pass is trying to compare start_idx 'None' to 0.
This diff fixes that.
Differential Revision: D72503552